Re-enable HITS in the python API using the new primitive-based implementation #1941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entation, cleaned up HITS tests to use benchmark fixture.
rlratzel
added
improvement
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #1941 +/- ##
===============================================
Coverage ? 70.35%
===============================================
Files ? 143
Lines ? 8903
Branches ? 0
===============================================
Hits ? 6264
Misses ? 2639
Partials ? 0 Continue to review full report at Codecov.
|
ChuckHastings
approved these changes
Nov 11, 2021
…or deprecated DiGraph classes.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
BradReesWork
approved these changes
Nov 11, 2021
jnke2016
approved these changes
Nov 11, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup PR to #1930
This PR re-enables HITS in the python API using the new C++ primitive-based implementation. This also refactors the tests to use the benchmark fixture plugin, and adds an additional dataset to read for more diverse comparison to Nx.